Fix keyboard brightness at 0, 1, 25 and 100 percent.#5413
Closed
sockbot wants to merge 1 commit intobasecamp:masterfrom
Closed
Fix keyboard brightness at 0, 1, 25 and 100 percent.#5413sockbot wants to merge 1 commit intobasecamp:masterfrom
sockbot wants to merge 1 commit intobasecamp:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Replaced PR with #5424 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5414
This PR sets keyboard backlight keys to use the fixed values of 0, 1, 25, and 100 percent corresponding to off, low, medium, and high.
Limiting the backlight settings to off, low, medium and high on my hardware provides a simplified and practical user experience to get an appropriate backlight level in fewer presses compared to steps of 10%. In addition, since the backlight strength is not linear, more discrete options do not add functionality (values of 50-100 are almost identical).
I chose the values of 0, 1, 25 and 100 because these subjectively looked like equidistant levels of brightness across the range.
Because this PR only exposes keyboard backlight values of off, low, medium and high I replaced the 100% scale bar with a simple text display:
Tested on MacBook Air 2014. Testing on additional hardware is welcome (and desired).