[#9882] Add implementation for TagOperations in python client(part2)#10554
Open
Abyss-lord wants to merge 2 commits intoapache:mainfrom
Open
[#9882] Add implementation for TagOperations in python client(part2)#10554Abyss-lord wants to merge 2 commits intoapache:mainfrom
Abyss-lord wants to merge 2 commits intoapache:mainfrom
Conversation
…art2) Add implementation for TagOperations in python client(part2)
Code Coverage Report
|
Contributor
Author
|
Hi @tsungchih , could you please review this PR when you have time? I’d really appreciate your feedback. |
tsungchih
reviewed
Mar 29, 2026
| TagUpdateRequest.UpdateTagCommentRequest, | ||
| TagUpdateRequest.SetTagPropertyRequest, | ||
| TagUpdateRequest.RemoveTagPropertyRequest, | ||
| ]: |
Collaborator
There was a problem hiding this comment.
All of the four requests are subclasses of TagUpdateRequestBase. I think we can define the return type as the base class.
| if isinstance(change, TagChange.RemoveProperty): | ||
| return TagUpdateRequest.RemoveTagPropertyRequest(change.removed_property) | ||
|
|
||
| raise ValueError(f"Unknown change type: {type(change)}") |
Collaborator
There was a problem hiding this comment.
We should raise the similar exception to the Java client, IllegalArgumentException.
| raise NotImplementedError() | ||
| url = self.API_METALAKES_TAGS_PATH.format(encode_string(self.name())) | ||
|
|
||
| response = self.rest_client.get(url, error_handler=TAG_ERROR_HANDLER) |
Collaborator
There was a problem hiding this comment.
I didn't see that parameters are sent with the API call similar to the Java client.
| tag_resp: TagResponse = TagResponse.from_json(response.body, infer_missing=True) | ||
| tag_resp.validate() | ||
|
|
||
| tag_resp.validate() |
Collaborator
There was a problem hiding this comment.
Is this statement, tag_resp,validate() redundant?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add rest implementation for
TagOperationsin python clientWhy are the changes needed?
Fix: #9882
Does this PR introduce any user-facing change?
Users can now manage tags using the
GravitinoClient.How was this patch tested?
local unittest