Skip to content

chore: Store all macro data on the client#9771

Merged
snowystinger merged 6 commits intomainfrom
store-all-macro-data-on-the-client
Mar 17, 2026
Merged

chore: Store all macro data on the client#9771
snowystinger merged 6 commits intomainfrom
store-all-macro-data-on-the-client

Conversation

@snowystinger
Copy link
Member

Closes

Sometimes the Dev tool doesn't display any properties. It may do it for one component but not its sibling. I'm not really sure why this is the case, but I suspect that it's due to messages either being dropped, or the receiving end not being ready, or a conflict.

Instead of sending data to the extension for storage, we keep it on the client and just query it from the extension. This should make it more dependable, it can't send information that isn't heard. In addition, it simplifies the communication we have to coordinate.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions bot added the S2 label Mar 10, 2026
@rspbot
Copy link

rspbot commented Mar 12, 2026

@rspbot
Copy link

rspbot commented Mar 17, 2026

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@rspbot
Copy link

rspbot commented Mar 17, 2026

@snowystinger snowystinger added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit c45205e Mar 17, 2026
29 checks passed
@snowystinger snowystinger deleted the store-all-macro-data-on-the-client branch March 17, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants