security fixes: Masqr.js hardening, cache cap, credentials, error pages#1193
Open
yetval wants to merge 4 commits intoUseInterstellar:mainfrom
Open
security fixes: Masqr.js hardening, cache cap, credentials, error pages#1193yetval wants to merge 4 commits intoUseInterstellar:mainfrom
yetval wants to merge 4 commits intoUseInterstellar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security fixes
Masqr.jsvia Host header — validate with allowlist regex, useURL.searchParams.set()for encodingauthcheckcookie is now signed (requiresCOOKIE_SECRETenv var); falls back to unsigned for non-Masqr deploymentshttpOnly,secure, andsameSiteflags to all Masqr cookiescookieParserbefore route handlers so Masqr actually gates/e/*requestsBug fixes
headers-already-sentcrash in asset proxy error handlermime.getType()returningnullfor unknown extensions (now falls back toapplication/octet-stream)__dirnameusingprocess.cwd()instead ofimport.meta.urlMasqFail()calls not being awaitedReliability
CACHE_MAX_ENTRIES(default 1000, env-configurable) to prevent OOM under adversarial traffichttp.Serverhandler instead of dead Express middlewareCredentials
config.js— credentials now read fromBASIC_AUTH_USERSenv var (user:passCSV)Error pages
static/500.html— 500 error handler was incorrectly serving404.htmlFailed.htmlnginx placeholder with a proper license-validation-failed pageNotes
MASQR=trueenv var; the import and setup block stay commented outCOOKIE_SECRETenv var is required at startup whenMASQR=true