fix(ui5-date-range-picker): remove relative date handling#13365
Open
fix(ui5-date-range-picker): remove relative date handling#13365
Conversation
Collaborator
|
🚀 Deployed on https://pr-13365--ui5-webcomponents-preview.netlify.app |
GDamyanov
requested changes
Apr 6, 2026
|
|
||
| describe("DateRangePicker relative dates rejection", () => { | ||
| it("typing 'today' sets error state", () => { | ||
| cy.mount(<DateRangePicker></DateRangePicker>); |
Contributor
There was a problem hiding this comment.
Most of the tests are executing same logic I suggest something like that:
const relativeKeywords = ["today", "tomorrow", "yesterday"];
relativeKeywords.forEach(keyword => {
it(`typing '${keyword}' sets error state`, () => {
cy.mount(<DateRangePicker></DateRangePicker>);
cy.get("[ui5-daterange-picker]")
.as("dateRangePicker")
.shadow()
.find("[ui5-datetime-input]")
.realClick()
.should("be.focused");
cy.realType(keyword);
cy.realPress("Enter");
cy.get("@dateRangePicker")
.should("have.value", keyword)
.should("have.attr", "value-state", "Negative");
});
});`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently our
ui5-daterange-pickerresolves relative dates like "today" and "tomorrow" to concrete dates. Thesap.m.DateRangeSelectiondoes not. It sets an error state instead, meaning that both project handles same scenarios in different ways causing inconsistencies.So in order to fix this we:
DateRangePickerisValid(),isValidValue(),isValidDisplayValue()to reject themWhat This Fixes
valueState="Negative"instead of resolvingsap.m.DateRangeSelectionDatePickercontinues resolving relative dates as before