The default implementation of bundle_samples specializes on Vector{T}, which in becomes very annoying if you want to implement your own bundle_samples, e.g. if you then use AbstractVector you almost immediately run into ambiguity errors.
|
function bundle_samples( |
|
samples::Vector, ::AbstractModel, ::AbstractSampler, ::Any, ::Type{Vector{T}}; kwargs... |
|
) where {T} |
|
return map(samples) do sample |
|
convert(T, sample) |
|
end |
|
end |
In addition, IIUC it seems quite "useless" given that by default sample already returns a Vector of the transitions?
Thoughts on removing this?
The default implementation of
bundle_samplesspecializes onVector{T}, which in becomes very annoying if you want to implement your ownbundle_samples, e.g. if you then useAbstractVectoryou almost immediately run into ambiguity errors.AbstractMCMC.jl/src/interface.jl
Lines 38 to 44 in 7192263
In addition, IIUC it seems quite "useless" given that by default
samplealready returns aVectorof the transitions?Thoughts on removing this?