Skip to content
This repository was archived by the owner on Jul 19, 2021. It is now read-only.
This repository was archived by the owner on Jul 19, 2021. It is now read-only.

Slate-tools using themekit 0.6.12 #1057

@JTimNolan

Description

@JTimNolan

Problem

Slate-tools is using a very old version of themekit. This seems to be causing some sort of issue for us when uploading our /config/settings_data.json file with it.

Replication steps

Run yarn watch
Update settings_data.json
In the background, the themekit command is run, but the file is not updated on Shopify
Running the same command with the current version of themekit 1.0.1 does update the file in shopify

More Information

I'm running slate on windows - aware this isn't tested/officially supported but other than this issue it's been working fine (and themekit should actually work on windows anyway).

I'm happy to submit a PR for this, but I wanted to check if there was any reason for using an old version of themekit before doing so

Edit - ended up fixing and patching this for my team anyway - so submitted #1058

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions