Replace winapi usage with windows#218
Open
damyanp wants to merge 1 commit intoRustAudio:masterfrom
Open
Conversation
The winapi crate is no longer maintained. This change ports everything over to use the more maintained windows crate.
Author
|
I don't know if there's any interest in a change like this. If there is, I'd be happy to spend a bit more time cleaning it up further. This replaces the need for #217. |
Member
|
Hello, yes there is very much interest in a change like this! 😃 Right now the focus for baseview is to update those foundational dependencies (namely from There are some conflicts and CI issues that need to be fixed first. If you are still interested in working on this, those are the first changes to make before this can be merged. 🙂 Thank you for this PR! |
prokopyl
requested changes
May 4, 2026
Member
prokopyl
left a comment
prokopyl
left a comment
There was a problem hiding this comment.
(as stated above, need to fix CI issues and resolve conflicts)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
winapicrate is no longer maintained. This change ports everything over to use thewindowscrate.