From 4b6c7fe5da149ee08435f7a90f0e04db3e788be8 Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Tue, 17 Mar 2026 12:53:46 -0500 Subject: [PATCH] [srock] Update srock-bin/README about incremental builds NFC. --- srock-bin/README | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/srock-bin/README b/srock-bin/README index 2667c1a30..36ba032fe 100644 --- a/srock-bin/README +++ b/srock-bin/README @@ -71,7 +71,8 @@ A: YES. This is useful if you have made development changes to any repository. Q: Is there a more incremental and faster way to rebuild the compiler? A: YES. One of the reasons build_srock.sh can be slow is that compiler changes - force a rebuild of rocgdb. To aovid this use ninja install, see step 8 and 9 below. + force a rebuild of rocgdb. To avoid this use ninja therock-dist from the + component build directory, see step 8 and 9 below. Q: What is the compiler development flow with srock? A: @@ -82,11 +83,11 @@ A: 5 cd $SROCK_REPOS/TheRock/compiler/amd-llvm 6 < make desired changes > 7 < Try incremental compile and install> -8 cd $SROCK_REPOS/TheRock/build/compiler/amd-llvm/build -9 ninja install +8 cd $SROCK_REPOS/TheRock/build/compiler/amd-llvm/build +9 ninja therock-dist 10 < if build fails, go to step 4> 11 < test your srock compiler. e.g.> -12 export AOMP=$HOME/rocm/srock +12 export AOMP=$SROCK_REPOS/TheRock/build/dist/rocm 13 cd $SROCK_REPOS/aomp/test/smoke 14 ./check_smoke.sh 15 < if fail, go to step 4> @@ -98,6 +99,11 @@ A: 21 git diff >$HOME/my.patch 22 < Apply my.patch to either trunk or downstream amd-staging branch > +Pay special attention to step 12: after an incremental rebuild, you should +set the AOMP environment variable to the build/dist/rocm directory in +TheRock's build tree, NOT to $HOME/rocm/srock as you may do after a full +"build_srock.sh" build. + Q: Why not just change the submodule file to point compiler repos to amd-staging branch? A: TheRock has frequent changes including submodule updates. The setup_srock.sh script correctly reintegrates these changes and then refixes the llvm-project and