From f320a958731ecc661b709c69e71c3736d0bb42b6 Mon Sep 17 00:00:00 2001 From: Oliver Hader Date: Tue, 28 Apr 2026 10:42:20 +0200 Subject: [PATCH 1/4] Fix dynamic property deprecation in TraverserTest Declare $html5 explicitly to avoid PHP 8.2+ deprecation warning about creation of dynamic class properties. --- test/HTML5/Serializer/TraverserTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/HTML5/Serializer/TraverserTest.php b/test/HTML5/Serializer/TraverserTest.php index 81dd444..09d7142 100644 --- a/test/HTML5/Serializer/TraverserTest.php +++ b/test/HTML5/Serializer/TraverserTest.php @@ -7,6 +7,11 @@ class TraverserTest extends \Masterminds\HTML5\Tests\TestCase { + /** + * @var \Masterminds\HTML5 + */ + protected $html5; + protected $markup = ' From d4ca88858ff021907ca1a742f31ca859ae5d38bc Mon Sep 17 00:00:00 2001 From: Oliver Hader Date: Tue, 28 Apr 2026 10:48:40 +0200 Subject: [PATCH 2/4] Fix dynamic property deprecation in TokenizerTest Drop unused $debug parameter and $scanner->debug assignment from createTokenizer/parse helpers to avoid PHP 8.2+ deprecation warning on Scanner instances. --- test/HTML5/Parser/TokenizerTest.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/test/HTML5/Parser/TokenizerTest.php b/test/HTML5/Parser/TokenizerTest.php index 86401c7..87d71a4 100644 --- a/test/HTML5/Parser/TokenizerTest.php +++ b/test/HTML5/Parser/TokenizerTest.php @@ -970,22 +970,20 @@ public function testText() // ================================================================ // Utility functions. // ================================================================ - protected function createTokenizer($string, $debug = false) + protected function createTokenizer($string) { $eventHandler = new EventStack(); $scanner = new Scanner($string); - $scanner->debug = $debug; - return array( new Tokenizer($scanner, $eventHandler), $eventHandler, ); } - public function parse($string, $debug = false) + public function parse($string) { - list($tok, $events) = $this->createTokenizer($string, $debug); + list($tok, $events) = $this->createTokenizer($string); $tok->parse(); return $events; From 0c53b0613e769d7dc77d07f2d41947897d04f624 Mon Sep 17 00:00:00 2001 From: Oliver Hader Date: Tue, 28 Apr 2026 11:00:29 +0200 Subject: [PATCH 3/4] Raise GitHub action runner to ubuntu-24.04 --- .github/workflows/benchmark.yaml | 2 +- .github/workflows/ci.yaml | 2 +- .github/workflows/cs.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml index dd84591..a2f8c4e 100644 --- a/.github/workflows/benchmark.yaml +++ b/.github/workflows/benchmark.yaml @@ -9,7 +9,7 @@ on: jobs: phpbench: name: "PHPBench" - runs-on: "ubuntu-20.04" + runs-on: "ubuntu-24.04" strategy: fail-fast: false diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 1ae2ed5..4533224 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ on: jobs: phpunit: name: "PHPUnit" - runs-on: "ubuntu-20.04" + runs-on: "ubuntu-24.04" strategy: fail-fast: false diff --git a/.github/workflows/cs.yaml b/.github/workflows/cs.yaml index 266666d..80e9a4c 100644 --- a/.github/workflows/cs.yaml +++ b/.github/workflows/cs.yaml @@ -9,7 +9,7 @@ on: jobs: php-cs-fixer: name: "php-cs-fixer" - runs-on: "ubuntu-20.04" + runs-on: "ubuntu-24.04" strategy: fail-fast: false From 8a0ed79fdf3a087ce5bfbcfda766eb92620bb7fd Mon Sep 17 00:00:00 2001 From: Oliver Hader Date: Tue, 28 Apr 2026 12:20:27 +0200 Subject: [PATCH 4/4] Raise GitHub action runner to ubuntu-latest --- .github/workflows/benchmark.yaml | 4 ++-- .github/workflows/ci.yaml | 2 +- .github/workflows/cs.yaml | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml index a2f8c4e..56c35b6 100644 --- a/.github/workflows/benchmark.yaml +++ b/.github/workflows/benchmark.yaml @@ -9,7 +9,7 @@ on: jobs: phpbench: name: "PHPBench" - runs-on: "ubuntu-24.04" + runs-on: "ubuntu-latest" strategy: fail-fast: false @@ -30,7 +30,7 @@ jobs: - name: "Install dependencies with Composer" uses: "ramsey/composer-install@v2" - + - name: Run performance tests run: | php test/benchmark/run.php 10 diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 4533224..a9fd54a 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -9,7 +9,7 @@ on: jobs: phpunit: name: "PHPUnit" - runs-on: "ubuntu-24.04" + runs-on: "ubuntu-latest" strategy: fail-fast: false diff --git a/.github/workflows/cs.yaml b/.github/workflows/cs.yaml index 80e9a4c..df375f9 100644 --- a/.github/workflows/cs.yaml +++ b/.github/workflows/cs.yaml @@ -9,7 +9,7 @@ on: jobs: php-cs-fixer: name: "php-cs-fixer" - runs-on: "ubuntu-24.04" + runs-on: "ubuntu-latest" strategy: fail-fast: false @@ -25,7 +25,7 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php-version }} - + - name: cs fix run: | wget -q https://github.com/FriendsOfPHP/PHP-CS-Fixer/releases/download/v2.19.3/php-cs-fixer.phar