-
-
Notifications
You must be signed in to change notification settings - Fork 109
API should always return renderable request files (remove frontend fallback) #7414
Copy link
Copy link
Open
Open
Copy link
Labels
javascriptPull requests that update Javascript codePull requests that update Javascript codephpPull requests that update Php codePull requests that update Php code
Description
Description
The signature-position flow currently depends on a frontend fallback because the editable request payload may arrive without renderable files.
This increases frontend complexity and hides API contract inconsistencies.
Expected behavior
The API response used by the signature-position modal should always include at least one renderable file entry, with consistent file data (id, name, and resolvable file/url).
Acceptance criteria
- Editable request payload always returns renderable files for Draft, Able to sign, and Partial signed states.
- Frontend fallback logic can be removed without breaking PDF rendering.
- Signature-position modal works without client-side reconstruction of file data.
- Backend tests cover cases where source data has missing/empty files and still produce a valid normalized response.
Impact
Simpler frontend, clearer API contract, fewer edge-case failures in signature positioning.Continued with AutopilotSummary: I provided a concise English GitHub issue draft with title, short problem statement, expected behavior, acceptance criteria, and impact, focused on fixing the API contract so the frontend fallback can be removed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
javascriptPull requests that update Javascript codePull requests that update Javascript codephpPull requests that update Php codePull requests that update Php code
Type
Projects
Status
0. Needs triage