Add HTTP protocol types, exception hierarchy, and MockHTTPResponse#23299
Closed
mwdd146980 wants to merge 1 commit intomasterfrom
Closed
Add HTTP protocol types, exception hierarchy, and MockHTTPResponse#23299mwdd146980 wants to merge 1 commit intomasterfrom
mwdd146980 wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 6686cd3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
Add three new utility modules to datadog_checks_base: - http_exceptions: Transport-agnostic HTTP exception hierarchy (HTTPError, HTTPStatusError, HTTPTimeoutError, etc.) - http_protocol: Protocol classes defining the HTTP client interface (HTTPClientProtocol, HTTPResponseProtocol) - http_testing: MockHTTPResponse for use in integration tests, replacing the requests-specific MockResponse from datadog_checks_dev These modules are purely additive and have no dependencies on existing code. They enable the ongoing httpx migration by providing library- agnostic abstractions that work with both requests and httpx backends. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mwdd146980
force-pushed
the
mwdd146980/base-http-modules
branch
from
f2eaf69 to
6686cd3
Compare
mwdd146980
added a commit
that referenced
this pull request
Apr 13, 2026
Remaining changes from the httpx migration feature branch (#22676), split out from the base modules PR (#23299). Includes: - mock_http fixture in datadog_checks_dev (pytest plugin) - test_mock_http_patches_agentcheck test (depends on mock_http) - AgentCheck.http property update for mock_http support - MockResponse → MockHTTPResponse migration across ~40 test files - vault and traefik_mesh production code updates - OpenMetrics scraper updates for http_protocol compatibility Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Validation Report
|
Contributor
Author
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add three new utility modules to datadog_checks_base:
These modules are purely additive and have no dependencies on existing code. They enable the ongoing httpx migration by providing library- agnostic abstractions that work with both requests and httpx backends.
Motivation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged